Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: upgrade mypy to 1.6.1#1705

Merged
Linchin merged 2 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
Linchin:mypy-upgradeLinchin/python-bigquery:mypy-upgradeCopy head branch name to clipboard
Oct 27, 2023
Merged

chore: upgrade mypy to 1.6.1#1705
Linchin merged 2 commits into
googleapis:maingoogleapis/python-bigquery:mainfrom
Linchin:mypy-upgradeLinchin/python-bigquery:mypy-upgradeCopy head branch name to clipboard

Conversation

@Linchin

@Linchin Linchin commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Upgrades mypy version to fix presubmit error.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1704 🦕

@Linchin Linchin added the dependencies Pull requests that update a dependency file label Oct 27, 2023
@Linchin Linchin requested review from a team and jainsahab October 27, 2023 19:25
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 27, 2023
@Linchin Linchin enabled auto-merge (squash) October 27, 2023 19:52
@Linchin Linchin requested a review from a team as a code owner October 27, 2023 21:48
@Linchin Linchin requested a review from m-strzelczyk October 27, 2023 21:48
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 27, 2023
@Linchin Linchin changed the title chore: upgrade mypy chore: upgrade mypy to 1.6.1 Oct 27, 2023
@Linchin Linchin mentioned this pull request Oct 27, 2023
Merged
@Linchin Linchin merged commit dfe1886 into googleapis:main Oct 27, 2023
@Linchin Linchin deleted the mypy-upgrade branch October 30, 2023 23:37
@Linchin Linchin mentioned this pull request Oct 31, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jainsahab jainsahab Awaiting requested review from jainsahab
@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk m-strzelczyk is a code owner automatically assigned from googleapis/python-samples-owners
1 more reviewer
@tswast tswast tswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. dependencies Pull requests that update a dependency file size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mypy test is failing

2 participants

@Linchin @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.