Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: allow storage_billing_model to be explicitly set to None to use project default value#1665

Merged
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
b302750597-storage_billing_modelgoogleapis/python-bigquery:b302750597-storage_billing_modelCopy head branch name to clipboard
Oct 2, 2023
Merged

fix: allow storage_billing_model to be explicitly set to None to use project default value#1665
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
b302750597-storage_billing_modelgoogleapis/python-bigquery:b302750597-storage_billing_modelCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Follow-up to #1643

Fixes internal issue 302750597 🦕

@tswast tswast requested review from a team and obada-ab October 2, 2023 14:35
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 2, 2023
@chalmerlowe

Copy link
Copy Markdown
Collaborator

This does not account for the fourth option that is available:

STORAGE_BILLING_MODEL_UNSPECIFIED

That should at least be called out in the comment.

@tswast
@Linchin

@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 2, 2023
@tswast

tswast commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

That should at least be called out in the comment.

Added!

IMO, the less client-side logic the better, but adding this in the docs makes sense to me.

@shollyman shollyman requested review from Linchin and chalmerlowe and removed request for obada-ab October 2, 2023 15:48

@chalmerlowe chalmerlowe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 514d3e1 into main Oct 2, 2023
@tswast tswast deleted the b302750597-storage_billing_model branch October 2, 2023 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.