Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs: revised create_partitioned_table sample#1447

Merged
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
issue790-bigquery_create_table_partitionedgoogleapis/python-bigquery:issue790-bigquery_create_table_partitionedCopy head branch name to clipboard
Oct 5, 2023
Merged

docs: revised create_partitioned_table sample#1447
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
issue790-bigquery_create_table_partitionedgoogleapis/python-bigquery:issue790-bigquery_create_table_partitionedCopy head branch name to clipboard

Conversation

@thejaredchapman

@thejaredchapman thejaredchapman commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium. and removed size: s Pull request size is small. labels Dec 20, 2022
@thejaredchapman thejaredchapman marked this pull request as ready for review December 21, 2022 17:03
@thejaredchapman thejaredchapman requested a review from a team December 21, 2022 17:03
@thejaredchapman thejaredchapman requested a review from a team as a code owner December 21, 2022 17:03
@thejaredchapman thejaredchapman requested review from a team and loferris December 21, 2022 17:03
@snippet-bot

snippet-bot Bot commented Dec 21, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tswast

tswast commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Kokoro test failures are real ones in this case:

nox > Running session mypy_samples
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/mypy_samples
nox > python -m pip install -e '.[all]'
nox > python -m pip install pytest
nox > python -m pip install -r /tmpfs/src/github/python-bigquery/samples/geography/requirements.txt
nox > python -m pip install -r /tmpfs/src/github/python-bigquery/samples/snippets/requirements.txt
nox > python -m pip install -r /tmpfs/src/github/python-bigquery/samples/magics/requirements.txt
nox > python -m pip install mypy==0.910
nox > python -m pip install types-mock types-pytz types-protobuf types-python-dateutil types-requests types-setuptools
nox > python -m pip install typing-extensions
nox > mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/
samples/snippets/create_partitioned_table_test.py:32: error: Name "client" is not defined
samples/snippets/create_partitioned_table_test.py:32: error: Name "to_delete" is not defined
samples/snippets/create_partitioned_table_test.py:34: error: Name "table" is not defined
samples/snippets/create_partitioned_table_test.py:35: error: Name "table" is not defined
samples/snippets/create_partitioned_table_test.py:36: error: Name "table" is not defined
Found 5 errors in 1 file (checked 222 source files)
nox > Command mypy --config-file /tmpfs/src/github/python-bigquery/samples/mypy.ini --no-incremental samples/ failed with exit code 1
nox > Session mypy_samples failed.

Need to update the sample & tests to use the new fixtures.

@meredithslota meredithslota requested a review from a team July 28, 2023 04:48
@tswast tswast force-pushed the issue790-bigquery_create_table_partitioned branch from af420a5 to ead525a Compare October 5, 2023 17:29
@tswast tswast enabled auto-merge (squash) October 5, 2023 17:30
@tswast tswast changed the title docs: Revised create_partitioned_table sample docs: revised create_partitioned_table sample Oct 5, 2023
@tswast tswast merged commit 40ba859 into main Oct 5, 2023
@tswast tswast deleted the issue790-bigquery_create_table_partitioned branch October 5, 2023 17:57
@release-please release-please Bot mentioned this pull request Oct 5, 2023
Merged
This was referenced Nov 7, 2023
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris
1 more reviewer
@tswast tswast tswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thejaredchapman @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.