Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: retry is_job_done on ConnectionError#1930

Merged
Linchin merged 1 commit into
maingoogleapis/python-bigquery:mainfrom
issue1929-retry-connectionerrorgoogleapis/python-bigquery:issue1929-retry-connectionerrorCopy head branch name to clipboard
May 23, 2024
Merged

fix: retry is_job_done on ConnectionError#1930
Linchin merged 1 commit into
maingoogleapis/python-bigquery:mainfrom
issue1929-retry-connectionerrorgoogleapis/python-bigquery:issue1929-retry-connectionerrorCopy head branch name to clipboard

Conversation

@tswast

@tswast tswast commented May 23, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1929 🦕

@tswast tswast requested review from a team and shollyman May 23, 2024 16:51
@tswast tswast mentioned this pull request May 23, 2024
Closed
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 23, 2024
@tswast tswast requested a review from Linchin May 23, 2024 19:07
Linchin
Linchin approved these changes May 23, 2024
View reviewed changes

@Linchin Linchin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Linchin Linchin merged commit 4f72723 into main May 23, 2024
@Linchin Linchin deleted the issue1929-retry-connectionerror branch May 23, 2024 19:48
@Linchin Linchin assigned Linchin and unassigned PhongChuong May 23, 2024
@release-please release-please Bot mentioned this pull request May 21, 2024
Merged
This was referenced Jun 11, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shollyman shollyman Awaiting requested review from shollyman
1 more reviewer
@Linchin Linchin Linchin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Linchin Linchin

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retry requests.exceptions.ConnectionError

3 participants

@tswast @Linchin @PhongChuong
Morty Proxy This is a proxified and sanitized view of the page, visit original site.