Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs: revised relax column mode sample#1467

Merged
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
issue790-relax_columngoogleapis/python-bigquery:issue790-relax_columnCopy head branch name to clipboard
Oct 5, 2023
Merged

docs: revised relax column mode sample#1467
tswast merged 2 commits into
maingoogleapis/python-bigquery:mainfrom
issue790-relax_columngoogleapis/python-bigquery:issue790-relax_columnCopy head branch name to clipboard

Conversation

@thejaredchapman

@thejaredchapman thejaredchapman commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@thejaredchapman thejaredchapman requested a review from a team January 17, 2023 20:54
@thejaredchapman thejaredchapman requested a review from a team as a code owner January 17, 2023 20:54
@thejaredchapman thejaredchapman requested review from a team, alvarowolfx and dandhlee January 17, 2023 20:54
@snippet-bot

snippet-bot Bot commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 17, 2023
tswast
tswast suggested changes Feb 27, 2023
View reviewed changes

@tswast tswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a TODO to snippets.py (or wherever the old sample is) to remove it after updating cloud.google.com

@meredithslota

meredithslota commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

This is missing the CLA — we can either override this (see the CLA details) or close this and open a new PR, since the CLA violations were only in merging main into this branch.

@tswast

tswast commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

This is missing the CLA — we can either override this (see the CLA details) or close this and open a new PR, since the CLA violations were only in merging main into this branch.

I'll rebase and force push to drop the bad merge commits.

@tswast tswast force-pushed the issue790-relax_column branch from 0276d5f to cbea873 Compare October 5, 2023 18:33
@tswast tswast requested a review from a team October 5, 2023 18:33
@tswast tswast changed the title docs: Revised relax_column sample docs: revised relax column mode sample Oct 5, 2023
@tswast tswast enabled auto-merge (squash) October 5, 2023 18:34
@tswast tswast merged commit b8c9276 into main Oct 5, 2023
@tswast tswast deleted the issue790-relax_column branch October 5, 2023 19:03
@release-please release-please Bot mentioned this pull request Oct 5, 2023
Merged
This was referenced Nov 7, 2023
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx
@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee is a code owner automatically assigned from googleapis/python-samples-owners
1 more reviewer
@tswast tswast tswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thejaredchapman @meredithslota @tswast
Morty Proxy This is a proxified and sanitized view of the page, visit original site.