This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Commit e118b02
* fix(job): honor custom retry in job.result()
The `_AsyncJob.result()` method was not correctly passing the `retry`
argument to the superclass's `result()` method when the `retry` object
was the same as the default retry object. This caused the default
retry settings to be ignored in some cases.
This change modifies the `result()` method to always pass the `retry`
argument to the superclass, ensuring that the provided retry settings
are always honored.
A new test case is added to verify that `job.result()` correctly
handles both the default retry and a custom retry object.
* Update tests/unit/test_job_retry.py
* Update tests/unit/test_job_retry.py
* blacken and lint
* udpates retry handling and testing of retry handling
* Update tests/unit/test_job_retry.py
* Update tests/unit/test_job_retry.py
* Update tests/unit/test_job_retry.py
---------
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 parent 63d7737 commit e118b02Copy full SHA for e118b02
2 files changed
+78-2Lines changed: 78 additions & 2 deletions
File tree
Expand file treeCollapse file tree
Open diff view settings
Filter options
- google/cloud/bigquery/job
- tests/unit
Expand file treeCollapse file tree
Open diff view settings
Collapse file
google/cloud/bigquery/job/base.py
Copy file name to clipboardExpand all lines: google/cloud/bigquery/job/base.py+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1044 | 1044 | |
1045 | 1045 | |
1046 | 1046 | |
1047 | | - |
1048 | | - |
| 1047 | + |
1049 | 1048 | |
1050 | 1049 | |
1051 | 1050 | |
|
Collapse file
tests/unit/test_job_retry.py
Copy file name to clipboardExpand all lines: tests/unit/test_job_retry.py+77Lines changed: 77 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
615 | 615 | |
616 | 616 | |
617 | 617 | |
| 618 | + |
| 619 | + |
| 620 | + |
| 621 | + |
| 622 | + |
| 623 | + |
| 624 | + |
| 625 | + |
| 626 | + |
| 627 | + |
| 628 | + |
| 629 | + |
| 630 | + |
| 631 | + |
| 632 | + |
| 633 | + |
| 634 | + |
| 635 | + |
| 636 | + |
| 637 | + |
| 638 | + |
| 639 | + |
| 640 | + |
| 641 | + |
| 642 | + |
| 643 | + |
| 644 | + |
| 645 | + |
| 646 | + |
| 647 | + |
| 648 | + |
| 649 | + |
| 650 | + |
| 651 | + |
| 652 | + |
| 653 | + |
| 654 | + |
| 655 | + |
| 656 | + |
| 657 | + |
| 658 | + |
| 659 | + |
| 660 | + |
| 661 | + |
| 662 | + |
| 663 | + |
| 664 | + |
| 665 | + |
| 666 | + |
| 667 | + |
| 668 | + |
| 669 | + |
| 670 | + |
| 671 | + |
| 672 | + |
| 673 | + |
| 674 | + |
| 675 | + |
| 676 | + |
| 677 | + |
| 678 | + |
| 679 | + |
| 680 | + |
| 681 | + |
| 682 | + |
| 683 | + |
| 684 | + |
| 685 | + |
| 686 | + |
| 687 | + |
| 688 | + |
| 689 | + |
| 690 | + |
| 691 | + |
| 692 | + |
| 693 | + |
| 694 | + |
0 commit comments