Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

improve __call__ performance benchmarking #15058

Copy link
Copy link

Description

@daniel-sanche
Issue body actions

In googleapis/python-api-core#527, we improved the performance of _GapicCallable's call method, and added a simple benchmark unit test to prevent performance from regressing too much

The test was very simple, using timeit to measure the time to run 10,000 calls, and dailing if it was slower than expected. This doesn't take performance of the worker into account, so the test may flake in different environments. To prevent this, we left a large buffer, but this means smaller regressions won't be caught by the test

@parthea suggested opening this issue to investigate improving the performance tests in the future. If we could test the performance of the old revision and the suggested change as part of the same test, we could make much better assertions on the performance of the library

CC @ohmayr

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.