Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

feat: Add grpc Compression argument to channels and methods#451

Merged
parthea merged 31 commits into
googleapis:maingoogleapis/python-api-core:mainfrom
acocuzzo:add-compressionacocuzzo/python-api-core:add-compressionCopy head branch name to clipboard
Sep 7, 2023
Merged

feat: Add grpc Compression argument to channels and methods#451
parthea merged 31 commits into
googleapis:maingoogleapis/python-api-core:mainfrom
acocuzzo:add-compressionacocuzzo/python-api-core:add-compressionCopy head branch name to clipboard

Conversation

@acocuzzo

Copy link
Copy Markdown
Contributor

The grpc library allows compression to be set the channel as well as call level
Fixes #450 🦕

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Sep 21, 2022
@acocuzzo acocuzzo changed the title (feat): Add grpc Compression argument to channels and methods feat: Add grpc Compression argument to channels and methods Sep 21, 2022
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 17, 2023
@acocuzzo acocuzzo marked this pull request as ready for review May 6, 2023 23:48
@acocuzzo acocuzzo requested review from a team May 6, 2023 23:48
Comment thread google/api_core/gapic_v1/method.py Outdated
@parthea parthea self-assigned this Sep 1, 2023

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one observation. @acocuzzo PTAL

Comment thread google/api_core/grpc_helpers.py Outdated
@parthea parthea assigned acocuzzo and unassigned parthea Sep 1, 2023
Comment thread google/api_core/operations_v1/operations_client.py Outdated
Comment thread google/api_core/operations_v1/operations_client.py Outdated
Comment thread google/api_core/operations_v1/operations_client.py Outdated
Comment thread google/api_core/operations_v1/operations_async_client.py Outdated
Comment thread google/api_core/operations_v1/operations_async_client.py Outdated
Comment thread google/api_core/operations_v1/operations_async_client.py Outdated
Comment thread google/api_core/operations_v1/operations_async_client.py Outdated
Comment thread google/api_core/operations_v1/operations_client.py Outdated
acocuzzo and others added 8 commits September 2, 2023 16:27
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@parthea parthea merged commit bdebd63 into googleapis:main Sep 7, 2023
This was referenced May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow passing grpc.Compression to grpc calls and channels

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.