Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: Improve transcoding error message#442

Merged
parthea merged 2 commits into
googleapis:maingoogleapis/python-api-core:mainfrom
vam-google:mastervam-google/python-api-core:masterCopy head branch name to clipboard
Sep 14, 2022
Merged

fix: Improve transcoding error message#442
parthea merged 2 commits into
googleapis:maingoogleapis/python-api-core:mainfrom
vam-google:mastervam-google/python-api-core:masterCopy head branch name to clipboard

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

This fixes #441 and #440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.

This fixes googleapis#441 and googleapis#440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.
@vam-google vam-google requested review from a team September 14, 2022 00:00
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Sep 14, 2022
@vam-google vam-google requested a review from parthea September 14, 2022 00:00
@parthea parthea changed the title fix: Improve transcodding error message fix: Improve transcoding error message Sep 14, 2022
@parthea parthea merged commit 538df80 into googleapis:main Sep 14, 2022
parthea pushed a commit that referenced this pull request Sep 14, 2022
* fix: Improve transcodding error message

This fixes #441 and #440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.

* reformat code with black
vam-google added a commit that referenced this pull request Sep 14, 2022
* fix: Improve transcodding error message

This fixes #441 and #440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.

* reformat code with black

Co-authored-by: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com>
This was referenced May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transcoding Error Improvements

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.