Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: VideoDataset class#253

Merged
morgandu merged 2 commits into
googleapis:devgoogleapis/python-aiplatform:devfrom
morgandu:mor--video-datasetmorgandu/python-aiplatform:mor--video-datasetCopy head branch name to clipboard
Mar 8, 2021
Merged

feat: VideoDataset class#253
morgandu merged 2 commits into
googleapis:devgoogleapis/python-aiplatform:devfrom
morgandu:mor--video-datasetmorgandu/python-aiplatform:mor--video-datasetCopy head branch name to clipboard

Conversation

@morgandu

@morgandu morgandu commented Mar 2, 2021

Copy link
Copy Markdown
Contributor
  • Added VideoDataset
  • Added unit tests for VideoDataset
  • Ensure the tests and linter pass

Fixes #https://b.corp.google.com/issues/179127058 🦕

@morgandu morgandu requested a review from a team March 2, 2021 19:38
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2021
@morgandu morgandu force-pushed the mor--video-dataset branch 2 times, most recently from 36e23d5 to 03906de Compare March 2, 2021 19:46

@sasha-gitg sasha-gitg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

from google.cloud.aiplatform import initializer
from google.cloud.aiplatform import schema
from google.cloud.aiplatform import utils
from google.cloud.aiplatform import datasets

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports should be alphabetical

@morgandu morgandu force-pushed the mor--video-dataset branch from 03906de to a7d3d23 Compare March 8, 2021 19:02
@morgandu morgandu merged commit abb9661 into googleapis:dev Mar 8, 2021
@morgandu morgandu deleted the mor--video-dataset branch March 8, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.