export aiplatform_v1beta1 as aiplatform.gapic_v1beta1#17
Merged
vinnysenthil merged 1 commit intoOct 2, 2020
googleapis:mastergoogleapis/python-aiplatform:masterfrom
dizcology:gapic-namespacedizcology/python-aiplatform:gapic-namespaceCopy head branch name to clipboard
Merged
export aiplatform_v1beta1 as aiplatform.gapic_v1beta1#17vinnysenthil merged 1 commit intogoogleapis:mastergoogleapis/python-aiplatform:masterfrom dizcology:gapic-namespacedizcology/python-aiplatform:gapic-namespaceCopy head branch name to clipboard
vinnysenthil merged 1 commit into
googleapis:mastergoogleapis/python-aiplatform:masterfrom
dizcology:gapic-namespacedizcology/python-aiplatform:gapic-namespaceCopy head branch name to clipboard
Conversation
vinnysenthil
approved these changes
Oct 2, 2020
Contributor
|
Namespace change has been LGTM'd |
Contributor
|
I'd prefer you actually create and put the code in that namespace. (i.e. move the code into Is the goal to split the generated layer from handwritten bits? |
Contributor
|
That is the goal, I'll let @dizcology follow up with a suggestion/decision. |
Contributor
Author
|
@software-dov could you point us to an example of setting namespace and name (https://github.com/googleapis/gapic-generator-python/blob/master/gapic/generator/options.py#L35-L36) through the GAPICMicrogenerator (https://github.com/googleapis/synthtool/blob/0762e8ee2ec21cdfc4d82020b985a104feb0453b/synthtool/gcp/gapic_microgenerator.py#L34)? |
sasha-gitg
added a commit
that referenced
this pull request
Oct 5, 2020
busunkim96
added a commit
that referenced
this pull request
Oct 20, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (#28) * clean up docstrings that are not rendered properly in reference doc (#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology
added a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (googleapis#28) * clean up docstrings that are not rendered properly in reference doc (googleapis#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (googleapis#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
dizcology
added a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology
added a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology
added a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic Co-authored-by: Yu-Han Liu <yuhanliu@google.com>
dizcology
added a commit
to dizcology/python-aiplatform
that referenced
this pull request
Nov 30, 2020
* Export aiplatform_v1beta1 as aiplatform.gapic_v1beta1 (googleapis#17) Freeing up the google.cloud.aiplatform namespace for MB SDK * GAPIC namespace (googleapis#20) * name space google.cloud.aiplatform.gapic * Init Disclaimer (googleapis#28) * clean up docstrings that are not rendered properly in reference doc (googleapis#24) Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> * fix: re-add py sessions to noxfile (googleapis#22) * fix: re-add py sessions to noxfile Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com> Co-authored-by: Yu-Han Liu <yuhanliu@google.com> Co-authored-by: Vinny Senthil <vinnysenthil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until confirmed about the approach.
Current user code (which will be broken after this change):
Expected user code after this change:
or