feat: Vertex Vizier support in SDK.#1434
Merged
Merged
feat: Vertex Vizier support in SDK.#1434
Conversation
…and system tests for them.
rosiezou
previously approved these changes
Jul 26, 2022
dismissing this review because all copy-pasted pyvizier code has been removed; additionally, all open comments have been addressed
rosiezou
approved these changes
Jul 27, 2022
Ark-kun
reviewed
Jul 28, 2022
| "absl-py>=0.7", | ||
| "numpy>=1.19.0", | ||
| "protobuf>=3.6,<4.0", | ||
| "keras-tuner>=1.0,<2.0", |
Contributor
There was a problem hiding this comment.
Where is keras-tuner used?
Ark-kun
reviewed
Dec 20, 2022
| "protobuf>=3.6,<4.0", | ||
| "keras-tuner>=1.0,<2.0", | ||
| "portpicker==1.3.1", | ||
| "googleapis-common-protos==1.56.0", |
Contributor
There was a problem hiding this comment.
Should these versions be so strict?
Ark-kun
reviewed
Dec 20, 2022
| "portpicker==1.3.1", | ||
| "googleapis-common-protos==1.56.0", | ||
| "google-api-python-client==1.12.8", | ||
| "google-vizier==0.0.3a", |
Contributor
There was a problem hiding this comment.
Are there any issues with supporting higher versions of vizier? 0.0.3a seems to be quite behind 0.0.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes # b/230767019 🦕