feat: add eval metrics types to get_experiment_df#1648
Merged
sararob merged 6 commits intoSep 9, 2022
googleapis:maingoogleapis/python-aiplatform:mainfrom
sararob:experiments-df-filtersararob/python-aiplatform:experiments-df-filterCopy head branch name to clipboard
Merged
feat: add eval metrics types to get_experiment_df#1648sararob merged 6 commits intogoogleapis:maingoogleapis/python-aiplatform:mainfrom sararob:experiments-df-filtersararob/python-aiplatform:experiments-df-filterCopy head branch name to clipboard
sararob merged 6 commits into
googleapis:maingoogleapis/python-aiplatform:mainfrom
sararob:experiments-df-filtersararob/python-aiplatform:experiments-df-filterCopy head branch name to clipboard
Conversation
sasha-gitg
approved these changes
Sep 7, 2022
SinaChavoshi
approved these changes
Sep 7, 2022
SinaChavoshi
left a comment
Contributor
There was a problem hiding this comment.
I think we should change the type name in schema classes artifact_schema.py to use the same constant as definitions in const file. However we can cover that in a separate cl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new Model Evaluation metric schema types to
get_experiment_df. With this addition, callingget_experiment_dfwill return metrics produced by Model Evaluation pipelines.