This repository was archived by the owner on Apr 7, 2026. It is now read-only.
fix: recalculate remaining statement timeout after retry#4053
Merged
olavloite merged 1 commit intoSep 23, 2025
maingoogleapis/java-spanner:mainfrom
recalculate-remaining-timeout-after-retrygoogleapis/java-spanner:recalculate-remaining-timeout-after-retryCopy head branch name to clipboard
Merged
fix: recalculate remaining statement timeout after retry#4053olavloite merged 1 commit intomaingoogleapis/java-spanner:mainfrom recalculate-remaining-timeout-after-retrygoogleapis/java-spanner:recalculate-remaining-timeout-after-retryCopy head branch name to clipboard
olavloite merged 1 commit into
maingoogleapis/java-spanner:mainfrom
recalculate-remaining-timeout-after-retrygoogleapis/java-spanner:recalculate-remaining-timeout-after-retryCopy head branch name to clipboard
Conversation
olavloite
force-pushed
the
recalculate-remaining-timeout-after-retry
branch
from
September 22, 2025 14:02
2f72a61 to
d384ba5
Compare
olavloite
force-pushed
the
recalculate-remaining-timeout-after-retry
branch
2 times, most recently
from
September 22, 2025 15:44
dec4241 to
a7b0f87
Compare
If a connection has a statement timeout and a statement is executed in a read/write transaction, the statement timeout would be reset to the original value during each retry, instead of being reduced after each attempt. This could cause multiple transaction retries to make the execution of a single statement take much longer than the configured timeout value.
olavloite
force-pushed
the
recalculate-remaining-timeout-after-retry
branch
from
September 22, 2025 16:24
bd0afb8 to
7ae9eed
Compare
rahul2393
approved these changes
Sep 22, 2025
rayudu3745
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a connection has a statement timeout and a statement is executed in a read/write transaction, the statement timeout would be reset to the original value during each retry, instead of being reduced after each attempt. This could cause multiple transaction retries to make the execution of a single statement take much longer than the configured timeout value.