docs(samples): Refactoring events package (new) by dfirova · Pull Request #481 · googleapis/java-retail

dfirova · Jul 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

dfirova · Aug 1, 2022

@kurtisvg returned commented parts with "check error handling", as they are part of the tutorials.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dfirova · Aug 31, 2022

@averikitsch Kokoro tests haven't run in 15 days.

dfirova · Sep 7, 2022

@chenlei1216 It's been almost a week and the owlBot check hasn't run yet.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2022-09-16) ### Features * add local inventories info to the Product resource ([8204fbc](8204fbc)) * release AttributesConfig APIs to v2 version ([8204fbc](8204fbc)) * release CompletionConfig APIs to v2 version ([8204fbc](8204fbc)) * Release Control and ServingConfig serivces to v2 version ([#522](#522)) ([8204fbc](8204fbc)) ### Bug Fixes * **samples:** Removed add time from lro. ([#530](#530)) ([541e280](541e280)) * **samples:** Removed env variables and buckets from creating bq. ([#526](#526)) ([67152a6](67152a6)) * **samples:** Removed region tags ([#531](#531)) ([2d0dd5c](2d0dd5c)) ### Documentation * Improved documentation for Fullfillment and Inventory API in ProductService ([8204fbc](8204fbc)) * minor documentation format and typo fixes ([8204fbc](8204fbc)) * **samples:** Refactoring events package ([#481](#481)) ([20d2539](20d2539)) * **samples:** Refactoring product package ([#480](#480)) ([0c39897](0c39897)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](#503)) ([435df1b](435df1b)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](#519)) ([9c37ee3](9c37ee3)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](#523)) ([0da80f8](0da80f8)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](#524)) ([ecb986a](ecb986a)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](#535)) ([e7fa004](e7fa004)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](#533)) ([6236b06](6236b06)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](#538)) ([ab71781](ab71781)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](#511)) ([364b3d4](364b3d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.5.0](googleapis/java-retail@v2.4.0...v2.5.0) (2022-09-16) ### Features * add local inventories info to the Product resource ([32a384d](googleapis/java-retail@32a384d)) * release AttributesConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d)) * release CompletionConfig APIs to v2 version ([32a384d](googleapis/java-retail@32a384d)) * Release Control and ServingConfig serivces to v2 version ([#522](googleapis/java-retail#522)) ([32a384d](googleapis/java-retail@32a384d)) ### Bug Fixes * **samples:** Removed add time from lro. ([#530](googleapis/java-retail#530)) ([858b0e1](googleapis/java-retail@858b0e1)) * **samples:** Removed env variables and buckets from creating bq. ([#526](googleapis/java-retail#526)) ([eeb68fa](googleapis/java-retail@eeb68fa)) * **samples:** Removed region tags ([#531](googleapis/java-retail#531)) ([b12a8fe](googleapis/java-retail@b12a8fe)) ### Documentation * Improved documentation for Fullfillment and Inventory API in ProductService ([32a384d](googleapis/java-retail@32a384d)) * minor documentation format and typo fixes ([32a384d](googleapis/java-retail@32a384d)) * **samples:** Refactoring events package ([#481](googleapis/java-retail#481)) ([c644df0](googleapis/java-retail@c644df0)) * **samples:** Refactoring product package ([#480](googleapis/java-retail#480)) ([aebf241](googleapis/java-retail@aebf241)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#503](googleapis/java-retail#503)) ([58a7105](googleapis/java-retail@58a7105)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#519](googleapis/java-retail#519)) ([dc52906](googleapis/java-retail@dc52906)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#523](googleapis/java-retail#523)) ([3ad9ecf](googleapis/java-retail@3ad9ecf)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#524](googleapis/java-retail#524)) ([2b6c293](googleapis/java-retail@2b6c293)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#535](googleapis/java-retail#535)) ([826cbd6](googleapis/java-retail@826cbd6)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#533](googleapis/java-retail#533)) ([29807c8](googleapis/java-retail@29807c8)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#538](googleapis/java-retail#538)) ([e4170e8](googleapis/java-retail@e4170e8)) * Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#511](googleapis/java-retail#511)) ([2c435e5](googleapis/java-retail@2c435e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sborisenkox added 2 commits July 1, 2022 11:54

Refactoring events package.

23ddd88

Remove init package.

9bade5d

dfirova requested review from a team July 1, 2022 08:55

product-auto-label Bot added size: l Pull request size is large. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Jul 1, 2022

blunderbuss-gcf Bot assigned kurtisvg Jul 1, 2022

kurtisvg suggested changes Jul 13, 2022

View reviewed changes

chenlei1216 reviewed Jul 14, 2022

View reviewed changes

Comment thread samples/interactive-tutorials/src/main/java/events/setup/RemoveEventsResources.java Outdated

Comment thread samples/interactive-tutorials/src/test/java/events/setup/EventsCreateBigQueryTableTest.java Outdated

dfirova added 3 commits July 15, 2022 13:19

PR fixes: Fixed ImportUserEventsBigQuery.

c32a7b0

PR fix: fixed delete of buckets and events.

ff7ce0e

PR fix: removed tests for setup/cleanup.

a0b6e37

dfirova requested review from chenlei1216 and kurtisvg July 19, 2022 05:24

chenlei1216 mentioned this pull request Jul 20, 2022

docs(samples): Refactoring product package (Import) (new) #480

Merged

4 tasks

chenlei1216 approved these changes Jul 20, 2022

View reviewed changes

dfirova mentioned this pull request Jul 26, 2022

fix (samples) Import user events GCS: given gsc input path was not found #493

Closed

4 tasks

kurtisvg suggested changes Jul 27, 2022

View reviewed changes

PR fix: added comments and removed unnecessary code lines.

ea8622e

dfirova requested a review from kurtisvg July 28, 2022 10:03

kurtisvg suggested changes Jul 28, 2022

View reviewed changes

Comment thread samples/interactive-tutorials/src/main/java/events/ImportUserEventsGcs.java Outdated

dfirova and others added 2 commits July 29, 2022 11:29

PR fix: typo

2ae878d

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

PR fixes: changed code according to the guidelines.

b9ed444

dfirova requested a review from kurtisvg August 1, 2022 06:10

PR fixes: returned error handling steps from the tutorial.

d31b3c7

kurtisvg approved these changes Aug 1, 2022

View reviewed changes

alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022

Merge branch 'main' into refactoring-events

2da20aa

averikitsch added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 12, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2022

🦉 Updates from OwlBot post-processor

e37c0ac

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

averikitsch added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 15, 2022

blakeli0 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 31, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2022

dfirova added 2 commits September 1, 2022 09:05

Merge branch 'main' into refactoring-events

3caaaf8

PR fix: returned test to previous state.

4aaa3df

averikitsch added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022

yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022

chenlei1216 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2022

gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2022

🦉 Updates from OwlBot post-processor

69ac31f

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2022

kurtisvg merged commit 20d2539 into googleapis:main Sep 13, 2022

release-please Bot mentioned this pull request Sep 13, 2022

chore(main): release 2.5.0 #532

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs(samples): Refactoring events package (new)#481

docs(samples): Refactoring events package (new)#481
kurtisvg merged 18 commits into
googleapis:maingoogleapis/java-retail:mainfrom
dfirova:refactoring-eventsdfirova/java-retail:refactoring-eventsCopy head branch name to clipboard

dfirova commented Jul 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dfirova commented Aug 1, 2022

Uh oh!

dfirova commented Aug 31, 2022

Uh oh!

dfirova commented Sep 7, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

dfirova commented Jul 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dfirova commented Aug 1, 2022

Uh oh!

dfirova commented Aug 31, 2022

Uh oh!

dfirova commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

dfirova commented Sep 7, 2022 •

edited

Loading