This repository was archived by the owner on Sep 16, 2023. It is now read-only.
Merged
docs(samples): added account defender samples and tests#771
Conversation
suztomo
reviewed
Apr 27, 2022
suztomo
reviewed
Apr 28, 2022
# Conflicts: # samples/snippets/cloud-client/src/main/java/recaptcha/account_defender/AccountDefenderAssessment.java
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
suztomo
reviewed
May 11, 2022
| String recaptchaAction = "recaptcha-action"; | ||
|
|
||
| // Unique ID of the customer, such as email, customer ID, etc. | ||
| String uniqueCustomerId = "default" + UUID.randomUUID().toString().split("-")[0]; |
Member
There was a problem hiding this comment.
Did you consider to align the variable names to the documentation?
https://cloud.google.com/recaptcha-enterprise/docs/account-defender#interpret-assessment-details uses "user identifier", not "customer ID".
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out! Changed the var name. PTAL
Member
|
Looks good to me. I don't have sample readability. Let me find appropriate reviewer. |
eaball35
self-requested a review
May 16, 2022 15:43
eaball35
approved these changes
May 16, 2022
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
May 24, 2022
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.0...v2.6.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-recaptchaenterprise/issues/1440)) ([#799](#799)) ([dddabca](dddabca)) ### Documentation * **samples:** added account defender samples and tests ([#771](#771)) ([eca03a1](eca03a1)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#795](#795)) ([fcdd308](fcdd308)) * update dependency org.springframework.boot:spring-boot-starter-test to v2.7.0 ([#796](#796)) ([2aa3477](2aa3477)) * update dependency org.springframework.boot:spring-boot-starter-thymeleaf to v2.7.0 ([#797](#797)) ([2aac201](2aac201)) * update dependency org.springframework.boot:spring-boot-starter-web to v2.7.0 ([#798](#798)) ([abfb369](abfb369)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions Bot
pushed a commit
to meltsufin/monorepo-experiments
that referenced
this pull request
May 24, 2022
🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-recaptchaenterprise@v2.5.0...v2.6.0) (2022-05-19) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-recaptchaenterprise/issues/1440)) ([#799](googleapis/java-recaptchaenterprise#799)) ([9e5d4da](googleapis/java-recaptchaenterprise@9e5d4da)) ### Documentation * **samples:** added account defender samples and tests ([#771](googleapis/java-recaptchaenterprise#771)) ([77992d1](googleapis/java-recaptchaenterprise@77992d1)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#795](googleapis/java-recaptchaenterprise#795)) ([365a84f](googleapis/java-recaptchaenterprise@365a84f)) * update dependency org.springframework.boot:spring-boot-starter-test to v2.7.0 ([#796](googleapis/java-recaptchaenterprise#796)) ([33674ee](googleapis/java-recaptchaenterprise@33674ee)) * update dependency org.springframework.boot:spring-boot-starter-thymeleaf to v2.7.0 ([#797](googleapis/java-recaptchaenterprise#797)) ([91e2e99](googleapis/java-recaptchaenterprise@91e2e99)) * update dependency org.springframework.boot:spring-boot-starter-web to v2.7.0 ([#798](googleapis/java-recaptchaenterprise#798)) ([92ff237](googleapis/java-recaptchaenterprise@92ff237)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added samples and tests for reCAPTCHA Enterprise Account Defender.