Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: Fix error message in MessageDispatcher.#47

Merged
hannahrogers-google merged 1 commit into
googleapis:mastergoogleapis/java-pubsub:masterfrom
desmond:patch-1Copy head branch name to clipboard
Jan 29, 2020
Merged

chore: Fix error message in MessageDispatcher.#47
hannahrogers-google merged 1 commit into
googleapis:mastergoogleapis/java-pubsub:masterfrom
desmond:patch-1Copy head branch name to clipboard

Conversation

@desmond

@desmond desmond commented Jan 2, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Grammar fix.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2020
@kamalaboulhosn kamalaboulhosn self-requested a review January 2, 2020 15:16
@desmond desmond changed the title Fix error message in MessageDispatcher. chore: Fix error message in MessageDispatcher. Jan 2, 2020
@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2020
@codecov

codecov Bot commented Jan 29, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #47 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #47      +/-   ##
============================================
+ Coverage     78.85%   78.86%   +<.01%     
- Complexity      288      290       +2     
============================================
  Files            21       21              
  Lines          2578     2583       +5     
  Branches        128      128              
============================================
+ Hits           2033     2037       +4     
  Misses          490      490              
- Partials         55       56       +1
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/pubsub/v1/MessageDispatcher.java 84.92% <ø> (-0.21%) 24 <0> (+1)
...a/com/google/cloud/pubsub/v1/TopicAdminClient.java 63.7% <0%> (ø) 30% <0%> (ø) ⬇️
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 66.18% <0%> (ø) 46% <0%> (ø) ⬇️
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 79.32% <0%> (+0.11%) 21% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0a7b2...93e0855. Read the comment docs.

@hannahrogers-google hannahrogers-google merged commit c618bc8 into googleapis:master Jan 29, 2020
@yoshi-automation yoshi-automation mentioned this pull request Jan 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@desmond @kamalaboulhosn @googlebot @yoshi-kokoro @hannahrogers-google
Morty Proxy This is a proxified and sanitized view of the page, visit original site.