Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: add keepalive feature to tear down streams in their absence#2605

Merged
michaelpri10 merged 4 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
SamuelSchaub:mainSamuelSchaub/java-pubsub:mainCopy head branch name to clipboard
Dec 1, 2025
Merged

feat: add keepalive feature to tear down streams in their absence#2605
michaelpri10 merged 4 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
SamuelSchaub:mainSamuelSchaub/java-pubsub:mainCopy head branch name to clipboard

Conversation

@SamuelSchaub

@SamuelSchaub SamuelSchaub commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@SamuelSchaub SamuelSchaub requested a review from a team October 28, 2025 21:33
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/java-pubsub API. labels Oct 28, 2025
@SamuelSchaub SamuelSchaub changed the title add keepalive feature to tear down streams in their absence feat: add keepalive feature to tear down streams in their absence Oct 28, 2025
@michaelpri10

michaelpri10 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@SamuelSchaub

SamuelSchaub commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

2 similar comments
@SamuelSchaub

SamuelSchaub commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

@michaelpri10

michaelpri10 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@SamuelSchaub

SamuelSchaub commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

@SamuelSchaub

SamuelSchaub commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@michaelpri10

michaelpri10 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@michaelpri10 michaelpri10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 30, 2025
michaelpri10
michaelpri10 suggested changes Oct 31, 2025
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java Outdated
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
@SamuelSchaub SamuelSchaub force-pushed the main branch 2 times, most recently from 1d72626 to 4b4f2b3 Compare November 3, 2025 20:10
@SamuelSchaub

SamuelSchaub commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

2 similar comments
@SamuelSchaub

SamuelSchaub commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

@michaelpri10

michaelpri10 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@michaelpri10 michaelpri10 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@michaelpri10

michaelpri10 commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@SamuelSchaub

SamuelSchaub commented Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@michaelpri10

michaelpri10 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@SamuelSchaub

SamuelSchaub commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

2 similar comments
@SamuelSchaub

SamuelSchaub commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

@michaelpri10

michaelpri10 commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@SamuelSchaub

SamuelSchaub commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment
@michaelpri10

michaelpri10 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

/gcbrun

@michaelpri10 michaelpri10 merged commit 99aca4f into googleapis:main Dec 1, 2025
25 of 27 checks passed
This was referenced Dec 11, 2025
Merged
Merged
@ccudennec-otto ccudennec-otto mentioned this pull request Dec 22, 2025
Closed
@michaelpri10 michaelpri10 mentioned this pull request Jan 27, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@michaelpri10 michaelpri10 michaelpri10 approved these changes
@abbrowne126 abbrowne126 abbrowne126 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@michaelpri10 michaelpri10

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SamuelSchaub @michaelpri10 @abbrowne126 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.