Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: Deflake WaiterTest#2600

Merged
michaelpri10 merged 7 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:waiter-testmichaelpri10/java-pubsub:waiter-testCopy head branch name to clipboard
Oct 21, 2025
Merged

fix: Deflake WaiterTest#2600
michaelpri10 merged 7 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:waiter-testmichaelpri10/java-pubsub:waiter-testCopy head branch name to clipboard

Conversation

@michaelpri10

@michaelpri10 michaelpri10 commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Deflake the WaiterTest by adding more logic to ensure that the Waiter is waiting before we advance the clock.

Fixes #2596

@michaelpri10 michaelpri10 requested review from a team October 21, 2025 14:56
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Oct 21, 2025
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 21, 2025
@michaelpri10 michaelpri10 changed the title chore: Deflake WaiterTest fix: Deflake WaiterTest Oct 21, 2025
@michaelpri10 michaelpri10 requested a review from lqiu96 October 21, 2025 16:50

@feywind feywind left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

@michaelpri10 michaelpri10 merged commit 298c8db into googleapis:main Oct 21, 2025
153 of 155 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WaiterTest test is stuck and won't finish running

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.