Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: track batch size using serialized size of PublishRequest#2113

Merged
michaelpri10 merged 8 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
sjvanrossum:mainsjvanrossum/java-pubsub:mainCopy head branch name to clipboard
Oct 11, 2024
Merged

feat: track batch size using serialized size of PublishRequest#2113
michaelpri10 merged 8 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
sjvanrossum:mainsjvanrossum/java-pubsub:mainCopy head branch name to clipboard

Conversation

@sjvanrossum

@sjvanrossum sjvanrossum commented Jul 12, 2024 •
edited
Loading

Copy link
Copy Markdown
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2106 ☕️

@sjvanrossum sjvanrossum requested a review from a team July 12, 2024 14:31
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jul 12, 2024
@sjvanrossum sjvanrossum mentioned this pull request Jul 12, 2024
Closed
michaelpri10
michaelpri10 suggested changes Oct 10, 2024
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
@michaelpri10

michaelpri10 commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

/gcbrun

@michaelpri10 michaelpri10 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 10, 2024
michaelpri10
michaelpri10 reviewed Oct 10, 2024
View reviewed changes
Comment thread google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
@michaelpri10

michaelpri10 commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

/gcbrun

@michaelpri10 michaelpri10 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2024
@michaelpri10 michaelpri10 merged commit be78e64 into googleapis:main Oct 11, 2024
@release-please release-please Bot mentioned this pull request Oct 11, 2024
Merged
@release-please release-please Bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@michaelpri10 michaelpri10 michaelpri10 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@michaelpri10 michaelpri10

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request batching does not track encoding overhead accurately

3 participants

@sjvanrossum @michaelpri10 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.