This repository was archived by the owner on May 8, 2026. It is now read-only.
RFC: Allow REST transport for PubSub Java client.#2075
Closed
sanjivr wants to merge 1 commit into
Closed
RFC: Allow REST transport for PubSub Java client.#2075sanjivr wants to merge 1 commit into
sanjivr wants to merge 1 commit into
Conversation
This leverages capabilities added in googleapis#1162
sanjivr
commented
Jun 13, 2024
| this.publishContextWithCompression = | ||
| GrpcCallContext.createDefault() | ||
| .withCallOptions(CallOptions.DEFAULT.withCompression(GZIP_COMPRESSION)); | ||
| this.enableRESTJsonTransport |
Author
There was a problem hiding this comment.
Note: If the user attempts to enable compression on the JSON transport, should the SDK throw an exception or silently ignore the same as the HttpJsonCallContext does not support compression ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Supports googleapis/google-cloud-java#13049
This leverages capabilities added in #1162
We're looking for input on whether