This repository was archived by the owner on May 8, 2026. It is now read-only.
fix: Use a separate cached thread pool for handling ack and modack response calllbacks for EOD-enabled subscriptions#2505
Merged
michaelpri10 merged 1 commit intoAug 5, 2025
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:eod-executor-fixmichaelpri10/java-pubsub:eod-executor-fixCopy head branch name to clipboard
Merged
fix: Use a separate cached thread pool for handling ack and modack response calllbacks for EOD-enabled subscriptions#2505michaelpri10 merged 1 commit intogoogleapis:maingoogleapis/java-pubsub:mainfrom michaelpri10:eod-executor-fixmichaelpri10/java-pubsub:eod-executor-fixCopy head branch name to clipboard
michaelpri10 merged 1 commit into
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:eod-executor-fixmichaelpri10/java-pubsub:eod-executor-fixCopy head branch name to clipboard
Conversation
…sponse callback for EOD-enabled subscriptions
abbrowne126
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the
MoreExecutors.directExecutor()docstring, "prefer not to perform any locking inside a task that will be run under {@code directExecutor}: Not only might the wait for a lock be long, but if the running thread was holding a lock, the listener may deadlock or break lock isolation."A lock is held during
notifyAckSuccesswhen EOD is enabled, which gets executed as a callback using aMoreExecutors.directExecutor(). This PR uses an a cached thread pool for executing this callback when EOD is enabled.Fixes #2480