Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

docs: Update emulator sample to create a topic and publish to it#2039

Merged
michaelpri10 merged 3 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:emulator-samplemichaelpri10/java-pubsub:emulator-sampleCopy head branch name to clipboard
Oct 3, 2024
Merged

docs: Update emulator sample to create a topic and publish to it#2039
michaelpri10 merged 3 commits into
googleapis:maingoogleapis/java-pubsub:mainfrom
michaelpri10:emulator-samplemichaelpri10/java-pubsub:emulator-sampleCopy head branch name to clipboard

Conversation

@michaelpri10

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested review from a team May 20, 2024 16:42
@snippet-bot

snippet-bot Bot commented May 20, 2024

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels May 20, 2024
@michaelpri10

michaelpri10 commented May 28, 2024

Copy link
Copy Markdown
Contributor Author

Note that this report is in response to internal code sample feedback (312895180).

@michaelpri10 michaelpri10 merged commit 21d5cfc into googleapis:main Oct 3, 2024
@michaelpri10 michaelpri10 deleted the emulator-sample branch October 3, 2024 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.