This repository was archived by the owner on Dec 3, 2023. It is now read-only.
Merged
fix: fix conversion for pre-epoch timestamps#160
Conversation
chingor13
force-pushed
the
fix-negative-timestamp
branch
from
February 19, 2020 21:37
0030226 to
0c32d16
Compare
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
============================================
+ Coverage 66.54% 66.56% +0.01%
- Complexity 370 371 +1
============================================
Files 34 34
Lines 1877 1881 +4
Branches 240 241 +1
============================================
+ Hits 1249 1252 +3
- Misses 526 527 +1
Partials 102 102
Continue to review full report at Codecov.
|
chingor13
marked this pull request as ready for review
February 19, 2020 21:50
codyoss
approved these changes
Feb 19, 2020
elharo
reviewed
Feb 19, 2020
elharo
reviewed
Feb 19, 2020
elharo
left a comment
Contributor
There was a problem hiding this comment.
also, haven't we seen this problem before a few months back? maybe in a different project?
Contributor
Author
I think this was something similar: googleapis/google-http-java-client#895 |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 27, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.93.0](https://www.github.com/googleapis/java-core/compare/v1.92.6...v1.93.0) (2020-02-27) ### Features * support conditional policies ([#110](https://www.github.com/googleapis/java-core/issues/110)) ([61e2d19](https://www.github.com/googleapis/java-core/commit/61e2d19bb4400978681aa018a8dc200214203830)) ### Bug Fixes * fix conversion for pre-epoch timestamps ([#160](https://www.github.com/googleapis/java-core/issues/160)) ([1f8b6b4](https://www.github.com/googleapis/java-core/commit/1f8b6b4835aaa702ec94bbbde89ed90f519c935a)) ### Dependencies * update dependency com.google.api:gax-bom to v1.54.0 ([#168](https://www.github.com/googleapis/java-core/issues/168)) ([5b52f9e](https://www.github.com/googleapis/java-core/commit/5b52f9e8d8cdc82b56114d3d1e857d137ae7ca98)) * update dependency io.grpc:grpc-bom to v1.27.2 ([#166](https://www.github.com/googleapis/java-core/issues/166)) ([28c9859](https://www.github.com/googleapis/java-core/commit/28c98595c9ee96760a063085bd85024177bd6dd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159