Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: Load balancing options for BigtableChannelPool#2667

Merged
gcf-merge-on-green[bot] merged 2 commits into
googleapis:maingoogleapis/java-bigtable:mainfrom
neilw4:load-balancerneilw4/java-bigtable:load-balancerCopy head branch name to clipboard
Sep 22, 2025
Merged

feat: Load balancing options for BigtableChannelPool#2667
gcf-merge-on-green[bot] merged 2 commits into
googleapis:maingoogleapis/java-bigtable:mainfrom
neilw4:load-balancerneilw4/java-bigtable:load-balancerCopy head branch name to clipboard

Conversation

@neilw4

@neilw4 neilw4 commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Experiments have shown that least-in-flight balancing is particularly effective when some channels or backends have problems.

Depends on: #2651

@neilw4 neilw4 requested review from a team September 4, 2025 14:27
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 4, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 11, 2025
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 11, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Sep 11, 2025

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left a couple of nits.

My only outstanding concern is for the least loaded algos. I think we need some protection for channels that are failing fast. So I think we need to track moving error ratios and if ratio crosses some threshold it short circuits least loaded comparison.

igorbernstein2
igorbernstein2 previously approved these changes Sep 19, 2025
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2025
Change-Id: I6f17513346350b9dc33f0d99407c829721e908e5
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 22, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2025
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 5adaa84 into googleapis:main Sep 22, 2025
23 of 25 checks passed
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2025
gcf-merge-on-green Bot pushed a commit that referenced this pull request Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.