Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: Move channel priming out of InstantiatingGrpcTransportProvider#2644

Merged
igorbernstein2 merged 20 commits into
googleapis:maingoogleapis/java-bigtable:mainfrom
nicholsl:chore/move-channel-priming-outnicholsl/java-bigtable:chore/move-channel-priming-outCopy head branch name to clipboard
Jul 30, 2025
Merged

chore: Move channel priming out of InstantiatingGrpcTransportProvider#2644
igorbernstein2 merged 20 commits into
googleapis:maingoogleapis/java-bigtable:mainfrom
nicholsl:chore/move-channel-priming-outnicholsl/java-bigtable:chore/move-channel-priming-outCopy head branch name to clipboard

Conversation

@nicholsl

@nicholsl nicholsl commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Change-Id: I7214aa3016bd7e7f7f167c64cbaa04134b54a352

Move towards longterm goal of using InstantiatingGrpcTransportProvider as a simple channel factory and towards BigtableChannelPrimer having access to BigtableChannelPool directly

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #2643 ☕️

If you write sample code, please follow the samples format.

@nicholsl nicholsl requested review from a team July 29, 2025 04:55
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jul 29, 2025
@nicholsl nicholsl changed the title move channel priming out of InstantiatingGrpcTransportProvider Move channel priming out of InstantiatingGrpcTransportProvider Jul 29, 2025
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Jul 29, 2025
mutianf
mutianf reviewed Jul 29, 2025
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
mutianf
mutianf previously approved these changes Jul 29, 2025
View reviewed changes

@mutianf mutianf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nits

Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
@mutianf mutianf changed the title Move channel priming out of InstantiatingGrpcTransportProvider chore: Move channel priming out of InstantiatingGrpcTransportProvider Jul 29, 2025
nicholsl added 3 commits July 29, 2025 10:17
@nicholsl
chore: Move channel priming out of InstantiatingGrpcTransportProvider
c73e0e7 
Change-Id: I7214aa3016bd7e7f7f167c64cbaa04134b54a352
@nicholsl
delete comment
9ad4c55 
Change-Id: I26d9b4929be6ba941eb88da05244fc031a747b68
@nicholsl
fixes
b535a44 
Change-Id: Ib414d250f9f1ce0555450e81a706f6c0619d80f2
@nicholsl nicholsl force-pushed the chore/move-channel-priming-out branch from 2ae875d to b535a44 Compare July 29, 2025 14:19
@nicholsl @mutianf
Update channel priming annotation
2ea5b3a 
Co-authored-by: Mattie Fu <mattiefu@google.com>
nicholsl and others added 2 commits July 29, 2025 10:21
@nicholsl @mutianf
Update google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/…
1a6f267 
…data/v2/stub/BigtableClientContext.java

Co-authored-by: Mattie Fu <mattiefu@google.com>
@nicholsl
fixes
27aa944 
Change-Id: I2f27c788652c9e5e12ea470355098c73b29ab40a
igorbernstein2
igorbernstein2 suggested changes Jul 29, 2025
View reviewed changes
Comment thread ...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
nicholsl added 5 commits July 29, 2025 13:34
@nicholsl
add no op channel primer
40d8c6c 
Change-Id: I343b3dc44d12638be2af32398b6aaa8529c7ebfb
@nicholsl
add noop channel primer test
19a5de2 
Change-Id: I2a11cd44ddd9caaea4db918f66aa7313a31a0057
@nicholsl
lint
39f3077 
Change-Id: Ifc564bcd182d4ea18e8e63ce78787281d589d8fd
@nicholsl
feat/add-async-channel-ping
4f29420 
Change-Id: I3e390b6f7a6c9beaee52d74f37ef557629af7759
@nicholsl
lint
3dff3cd 
Change-Id: I5e2b13674c7fc945d5567b7f86478c847017aa41
igorbernstein2
igorbernstein2 suggested changes Jul 29, 2025
View reviewed changes
Comment thread ...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java
Comment thread ...e-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/NoOpChannelPrimer.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
Comment thread ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated
nicholsl and others added 4 commits July 29, 2025 15:50
@nicholsl
fixes
e8288b0 
Change-Id: Ibaa32ee3425b23596a3141bb4e29cfb068caf0ee
@nicholsl
fixes
1693818 
Change-Id: I3d43864fee0b05cc64f27aabcb2ffaf84c9c0ab8
@nicholsl
minor change to test
b4cf91a 
Change-Id: I63f9f0e930f95d48ce56962e49d6bdca0fc5918d
@nicholsl
Merge pull request #1 from nicholsl/feat/add-async-channel-ping
97a0a9c 
feat/add-async-channel-ping

add an async channel pinging method to be used in channel health checking
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 29, 2025
igorbernstein2
igorbernstein2 previously approved these changes Jul 29, 2025
View reviewed changes
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2025
@nicholsl
clirr-ignored-differences.xml
9bf7576 
Change-Id: Ia4e25a7c80256762e241f30a585056aa78fb2878
@nicholsl nicholsl requested a review from a team July 29, 2025 21:27
nicholsl added 2 commits July 29, 2025 18:07
@nicholsl
increase timeout for testing purposes
8d07f8f 
Change-Id: I96fb32e098862546aae0de498637459c5a9e197d
@nicholsl
increase offset jitter to make more resilient to flakes
b6d4c59 
Change-Id: I8754683cae05ed9fd0267a1fd16746756450c15e
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jul 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
nicholsl added 2 commits July 30, 2025 13:12
@nicholsl
more fault tolerance
0d56011 
Change-Id: I997c3752d8b5ae13084762a7eb3fc6b042ead206
@nicholsl
revert flaky test changes
582cb46 
Change-Id: I8e0ad310444c754df71dc61782b23d007bbfdaba
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2025
@igorbernstein2 igorbernstein2 merged commit aeedb00 into googleapis:main Jul 30, 2025
32 of 35 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mutianf mutianf mutianf approved these changes
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chore: Move PingAndWarm outside of InstantiatingGrpcTransportProvider

4 participants

@nicholsl @mutianf @igorbernstein2 @yoshi-kokoro
Morty Proxy This is a proxified and sanitized view of the page, visit original site.