Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

test: add errorprone and fix all of the errors#2638

Merged
igorbernstein2 merged 1 commit into
maingoogleapis/java-bigtable:mainfrom
error-pronegoogleapis/java-bigtable:error-proneCopy head branch name to clipboard
Jul 21, 2025
Merged

test: add errorprone and fix all of the errors#2638
igorbernstein2 merged 1 commit into
maingoogleapis/java-bigtable:mainfrom
error-pronegoogleapis/java-bigtable:error-proneCopy head branch name to clipboard

Conversation

@igorbernstein2

@igorbernstein2 igorbernstein2 commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Change-Id: I273e614ab8d5e8e1bf73e031e80729dda0b2f0de

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
test: add errorprone and fix all of the errors
d84069f 
Change-Id: I273e614ab8d5e8e1bf73e031e80729dda0b2f0de
@igorbernstein2 igorbernstein2 requested review from a team July 21, 2025 19:45
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jul 21, 2025
jackdingilian
jackdingilian approved these changes Jul 21, 2025
View reviewed changes

@jackdingilian jackdingilian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/CookiesHolderTest.java
@igorbernstein2 igorbernstein2 merged commit a958811 into main Jul 21, 2025
27 checks passed
@igorbernstein2 igorbernstein2 deleted the error-prone branch July 21, 2025 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jackdingilian jackdingilian jackdingilian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igorbernstein2 @jackdingilian
Morty Proxy This is a proxified and sanitized view of the page, visit original site.