Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

test: clean up CookieHolderTest#2361

Merged
mutianf merged 5 commits into
maingoogleapis/java-bigtable:mainfrom
cookie-testgoogleapis/java-bigtable:cookie-testCopy head branch name to clipboard
Sep 27, 2024
Merged

test: clean up CookieHolderTest#2361
mutianf merged 5 commits into
maingoogleapis/java-bigtable:mainfrom
cookie-testgoogleapis/java-bigtable:cookie-testCopy head branch name to clipboard

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor
  • stop returning protos to trigger headers
  • fix thread safety for variables that are accessed by multiple threads

Change-Id: Ib34440d2ffeddcb5611b5e1cee183004bafc9449

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

- stop returning protos to trigger headers
- fix thread safety for variables that are accessed by multiple threads

Change-Id: Ib34440d2ffeddcb5611b5e1cee183004bafc9449
@igorbernstein2 igorbernstein2 requested review from a team September 27, 2024 17:44
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 27, 2024
Change-Id: Ied61bc081c3cc0220fd96051aabd1849cbffd10f
Change-Id: Ibf2f4ad8bea038390b1ddf099c3061f0d9b02495
Change-Id: I63a6e54829ef5ea2db8d3b3b2db0afdc89cc1248
Change-Id: I2296b1cb7f52895a59e6b4fe5586d07c0dfd97a2
@mutianf mutianf merged commit 29b23d7 into main Sep 27, 2024
@mutianf mutianf deleted the cookie-test branch September 27, 2024 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.