Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: add generator version to config#2334

Merged
JoeWang1127 merged 3 commits into
maingoogleapis/java-bigtable:mainfrom
chore/add-generator-versiongoogleapis/java-bigtable:chore/add-generator-versionCopy head branch name to clipboard
Sep 6, 2024
Merged

chore: add generator version to config#2334
JoeWang1127 merged 3 commits into
maingoogleapis/java-bigtable:mainfrom
chore/add-generator-versiongoogleapis/java-bigtable:chore/add-generator-versionCopy head branch name to clipboard

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Sep 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

In this PR:

  • Add generator version to generation config.

The library generation job failed due to config doesn't have a generator version, see https://github.com/googleapis/java-bigtable/actions/runs/10712723965/job/29703584291.

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 5, 2024
@JoeWang1127

JoeWang1127 commented Sep 5, 2024

Copy link
Copy Markdown
Contributor Author

Generation workflow failed. This is expected because config in main branch (baseline config) doesn't have a generator version.

  File "/src/cli/entry_point.py", line 129, in generate
    baseline_config=from_yaml(baseline_generation_config_path),
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/library_generation/model/generation_config.py", line 170, in from_yaml
    parsed_config = GenerationConfig(
                    ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/library_generation/model/generation_config.py", line 49, in __init__
    self.gapic_generator_version = GenerationConfig.__set_generator_version(
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/library_generation/model/generation_config.py", line 92, in __set_generator_version
    raise ValueError(
ValueError: Environment variable GENERATOR_VERSION is not set when the generator version is not specified in the generation config.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 5, 2024 21:16
@JoeWang1127 JoeWang1127 requested review from a team, blakeli0 and diegomarquezp September 5, 2024 21:16
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 5, 2024
@JoeWang1127 JoeWang1127 merged commit 8142a80 into main Sep 6, 2024
@JoeWang1127 JoeWang1127 deleted the chore/add-generator-version branch September 6, 2024 11:39
JoeWang1127 added a commit that referenced this pull request Sep 6, 2024
@JoeWang1127
Revert "chore: add generator version to config (#2334)"
80ebb77 
This reverts commit 8142a80.
@JoeWang1127 JoeWang1127 mentioned this pull request Sep 6, 2024
Merged
JoeWang1127 added a commit that referenced this pull request Sep 6, 2024
@JoeWang1127
chore: restore library generation workflow (#2335)
c618969 
* Revert "chore: add generator version to config (#2334)"

This reverts commit 8142a80.

* add generator version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@blakeli0 blakeli0 blakeli0 approved these changes
@diegomarquezp diegomarquezp diegomarquezp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoeWang1127 @blakeli0 @diegomarquezp
Morty Proxy This is a proxified and sanitized view of the page, visit original site.