Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on May 8, 2026. It is now read-only.

chore: remove native image sample in favor of sample hosted in google-cloud-java#2273

Merged
igorbernstein2 merged 5 commits into
maingoogleapis/java-bigtable:mainfrom
remove-native-image-samplegoogleapis/java-bigtable:remove-native-image-sampleCopy head branch name to clipboard
Aug 27, 2024
Merged

chore: remove native image sample in favor of sample hosted in google-cloud-java#2273
igorbernstein2 merged 5 commits into
maingoogleapis/java-bigtable:mainfrom
remove-native-image-samplegoogleapis/java-bigtable:remove-native-image-sampleCopy head branch name to clipboard

Conversation

@mpeddada1

Copy link
Copy Markdown
Contributor

This PR removes the redundant, library-specific bigtable native image sample in favor of a single sample maintained in https://github.com/googleapis/google-cloud-java/tree/main/java-samples/native-image-sample

Documented externally in https://cloud.google.com/java/docs/compile-native-images#whats_next

@mpeddada1 mpeddada1 requested review from a team July 3, 2024 18:36
@snippet-bot

snippet-bot Bot commented Jul 3, 2024

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Jul 3, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2024
@igorbernstein2 igorbernstein2 merged commit 78a19f0 into main Aug 27, 2024
@igorbernstein2 igorbernstein2 deleted the remove-native-image-sample branch August 27, 2024 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.