fix(storage): str() metadata for for blob#9796
Merged
crwilcox merged 4 commits intoNov 22, 2019
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:storage_str_metadata_for_blobMaxxleLLC/google-cloud-python:storage_str_metadata_for_blobCopy head branch name to clipboard
Merged
fix(storage): str() metadata for for blob#9796crwilcox merged 4 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom MaxxleLLC:storage_str_metadata_for_blobMaxxleLLC/google-cloud-python:storage_str_metadata_for_blobCopy head branch name to clipboard
crwilcox merged 4 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:storage_str_metadata_for_blobMaxxleLLC/google-cloud-python:storage_str_metadata_for_blobCopy head branch name to clipboard
Conversation
frankyn
suggested changes
Nov 14, 2019
| :type value: dict | ||
| :param value: (Optional) The blob metadata to set. | ||
| """ | ||
| value = {k: str(v) for k, v in value.items()} |
Contributor
There was a problem hiding this comment.
Thanks @HemangChothani!
Could you also add this to bucket labels given the similarity?
frankyn
approved these changes
Nov 15, 2019
frankyn
left a comment
Contributor
There was a problem hiding this comment.
Thanks @HemangChothani, lgtm!
crwilcox
approved these changes
Nov 22, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* fix(storage): fix stringify metadata for blob * fix(storage): fix lint fail * fix(storage): stringify labels for bucket * fix(storage): fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9729