Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(bigtable): add 'client_options' / 'admin_client_options' to Client#9517

Merged
tseaver merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:8475-bigtable-add-client_options-supportCopy head branch name to clipboard
Oct 24, 2019
Merged

feat(bigtable): add 'client_options' / 'admin_client_options' to Client#9517
tseaver merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:8475-bigtable-add-client_options-supportCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Toward #8475.

Supersedes #9289.

@tseaver tseaver added api: bigtable Issues related to the Bigtable API. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. labels Oct 22, 2019
@tseaver tseaver requested a review from busunkim96 October 22, 2019 22:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019
@tseaver tseaver changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Client. feat(bigtable): add 'client_info' / 'admin_client_info' to Client Oct 22, 2019
@tseaver

tseaver commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

@busunkim96 This looks to be the last open PR to complete #8475.

@busunkim96 busunkim96 changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Client feat(bigtable): add 'client_options' / 'admin_client_options' to Client Oct 22, 2019

@busunkim96 busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Comment thread bigtable/google/cloud/bigtable/client.py Outdated
Comment thread bigtable/google/cloud/bigtable/client.py Outdated
Comment thread bigtable/google/cloud/bigtable/client.py Outdated
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@tseaver

tseaver commented Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

Flaky systest reported in #9535.

@tseaver tseaver merged commit 2beaa95 into googleapis:master Oct 24, 2019
@tseaver tseaver deleted the 8475-bigtable-add-client_options-support branch October 24, 2019 18:33
parthea pushed a commit that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.