Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Release dns 0.30.2#8645

Merged
busunkim96 merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
busunkim96:release-dns-0.30.2busunkim96/google-cloud-python:release-dns-0.30.2Copy head branch name to clipboard
Jul 16, 2019
Merged

Release dns 0.30.2#8645
busunkim96 merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
busunkim96:release-dns-0.30.2busunkim96/google-cloud-python:release-dns-0.30.2Copy head branch name to clipboard

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2019
@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Jul 11, 2019

@tseaver tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if the answer to my question below is "No".

Comment thread dns/setup.py
name = 'google-cloud-dns'
description = 'Google Cloud DNS API client library'
version = '0.30.1'
version = '0.30.2'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the endpoint change is worth signalling with a minor release?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back to ask folks doing this in other languages what they're doing Will leave it open for now.

@busunkim96 busunkim96 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 11, 2019
@busunkim96

Copy link
Copy Markdown
Contributor Author

Merging as a patch, as other languages have done the same.

@busunkim96 busunkim96 merged commit 0f06c34 into googleapis:master Jul 16, 2019
@yoshi-automation

Copy link
Copy Markdown
Contributor

@yoshi-automation

Copy link
Copy Markdown
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation

Copy link
Copy Markdown
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.