Adding Bucket.lifecycle_rules property to replace methods. #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -674,75 +674,57 @@ def test_id(self): | ||
| bucket = self._makeOne(properties=properties) | ||
| self.assertEqual(bucket.id, ID) | ||
|
|
||
| def test_get_lifecycle_eager(self): | ||
| def test_location_getter(self): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I don't know why the out-of-order looking changes in the tests module occur. The main module bits LGTM. Since test coverage remains at 100%, we're probably good to go. |
|
Good deal. I'd guess GitHub uses the default (Myers / greedy) diff algorithm in |
dhermes
added a commit
that referenced
this pull request
Mar 30, 2015
Adding Bucket.lifecycle_rules property to replace methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #728