Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Making cors a property instead of having two separate methods. #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2015
Merged

Making cors a property instead of having two separate methods. #768

merged 1 commit into from
Mar 30, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

@tseaver based on your comment, this drops one of the non-property data access pairs. More importantly, it drops one of the internal users of patch().

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5d83599 on dhermes:make-cors-property into 4d69bb3 on GoogleCloudPlatform:master.

This was referenced Mar 28, 2015
Closed
Merged
tseaver
tseaver reviewed Mar 30, 2015
View reviewed changes
gcloud/storage/bucket.py
"""Retrieve CORS policies configured for this bucket.

See: http://www.w3.org/TR/cors/ and
https://cloud.google.com/storage/docs/json_api/v1/buckets

:rtype: list(dict)
:rtype: list

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM w/ exception of my :rtype: comment.

@dhermes dhermes force-pushed the make-cors-property branch from 5d83599 to 970e1c0 Compare March 30, 2015 18:56
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

Wrapped the change into the original commit and rebased after #774 just for fun

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 970e1c0 on dhermes:make-cors-property into f65f7c7 on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Mar 30, 2015
@dhermes
Merge pull request #768 from dhermes/make-cors-property
adc0029 
Making cors a property instead of having two separate methods.
@dhermes dhermes merged commit adc0029 into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the make-cors-property branch March 30, 2015 19:23
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @coveralls @tseaver @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.