BigQuery: populate timeout parameter for getQueryResults#4209
Merged
tswast merged 3 commits intoOct 18, 2017
Merged
BigQuery: populate timeout parameter for getQueryResults#4209
Conversation
This will allow QueryJob to respect the timeout value for futures.
theacodes
reviewed
Oct 17, 2017
| if self._done_timeout is not None: | ||
| # Subtract a buffer of a 100 milliseconds for context switching, | ||
| # network latency, etc. | ||
| timeout_ms = int(1000 * self._done_timeout) - 100 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| if self.state != _DONE_STATE: | ||
| self._query_results = self._client._get_query_results( | ||
| self.job_id, retry) | ||
| self.job_id, retry, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Oct 18, 2017
Contributor
Author
|
Circle error is with Pub/Sub. cloud.google.bigquery tests are passing. Discussed timeout exception in person. The timeout option for getQueryResults is a parameter, not enforced client-side. When the time expires, the API will return a successful response with the incomplete job state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow QueryJob to respect the timeout value for futures.
Closes #4135.