Simplifying usage of Client classes in Spanner and Bigtable#3671
Closed
dhermes wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:spanner-bigtable-simplerdhermes/google-cloud-python:spanner-bigtable-simplerCopy head branch name to clipboard
Closed
Simplifying usage of Client classes in Spanner and Bigtable#3671dhermes wants to merge 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:spanner-bigtable-simplerdhermes/google-cloud-python:spanner-bigtable-simplerCopy head branch name to clipboard
dhermes wants to merge 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:spanner-bigtable-simplerdhermes/google-cloud-python:spanner-bigtable-simplerCopy head branch name to clipboard
Conversation
Contributor
|
I'm gonna close this for now. This is helpful because it's revealed just how much refactoring will need to happen to use a new client superclass. With the move to google.api.core, I will introduce the new base classes, switch these to that, then drop |
Contributor
Author
|
@jonparrott At the very least the first commit should go in (just to push all of the warts into one place) |
Contributor
|
Agreed, do you wanna send a new PR with just that? |
Contributor
Author
|
I just force-pushed this branch with one fewer commit. |
Contributor
Author
|
And the force-push made it impossible to "Reopen and comment" |
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up commit, also simplifying the Client classes.
I am "throwing this up" as a half-finished PR so @jonparrott can take the wheel.