Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add system test for insert/fetch of rows w/ nested schema.#3140

Merged
tseaver merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:3029-bigquery-systest-insert-fetch-w-complex-schemaCopy head branch name to clipboard
Mar 21, 2017
Merged

Add system test for insert/fetch of rows w/ nested schema.#3140
tseaver merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:3029-bigquery-systest-insert-fetch-w-complex-schemaCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

Uses #3118 as a base.

Derived from schema / data from @tswast.

Toward #3029.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. testing labels Mar 14, 2017
@tseaver tseaver requested review from daspecster and dhermes March 14, 2017 20:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
@daspecster

Copy link
Copy Markdown
Contributor

@tseaver should be able to merge #3118 and rebase this off master.

Also, there's a lint error in this branch just FYI.

@tseaver

tseaver commented Mar 15, 2017

Copy link
Copy Markdown
Contributor Author

@daspecster, @dhermes Any issues?

Comment thread system_tests/bigquery.py
self.assertEqual(len(fetched), len(to_insert))

for found, expected in zip(sorted(fetched), sorted(to_insert)):
self.assertEqual(found[0], expected[0]) # Name

This comment was marked as spam.

This comment was marked as spam.

Comment thread system_tests/bigquery.py

for found, expected in zip(sorted(fetched), sorted(to_insert)):
self.assertEqual(found[0], expected[0]) # Name
self.assertEqual(found[1], int(expected[1])) # Age

This comment was marked as spam.

This comment was marked as spam.

Comment thread system_tests/bigquery.py

e_icon = base64.standard_b64decode(
e_spell['Icon'].encode('ascii'))
self.assertEqual(f_spell['Icon'], e_icon)

This comment was marked as spam.

This comment was marked as spam.

@@ -0,0 +1,66 @@
[

This comment was marked as spam.

This comment was marked as spam.

@tseaver

tseaver commented Mar 20, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes I think I answered your questions.

@tseaver

tseaver commented Mar 21, 2017

Copy link
Copy Markdown
Contributor Author

@dhermes, @lukesneeringer, @daspecster Any remaining issues?

@lukesneeringer

Copy link
Copy Markdown
Contributor

None from me. :-)

@tseaver tseaver merged commit 983783b into googleapis:master Mar 21, 2017
@tseaver tseaver deleted the 3029-bigquery-systest-insert-fetch-w-complex-schema branch March 21, 2017 16:55
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
…-insert-fetch-w-complex-schema

Add system test for insert/fetch of rows w/ nested schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.