Moving to iterators in DNS.#2532
Closed
dhermes wants to merge 1 commit into
Closed
Moving to iterators in DNS.#2532dhermes wants to merge 1 commit into
dhermes wants to merge 1 commit into
Conversation
ffca8d8 to
87c1bcc
Compare
Contributor
Author
|
@daspecster @tseaver @jonparrott PTAL. There will be about 5 more PRs like this for each package which does page token |
theacodes
approved these changes
Oct 17, 2016
theacodes
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty straightforward to me.
Contributor
Author
|
TRAVIS! |
Contributor
No travis for you, I used up all of his cycles in |
Contributor
Contributor
Author
ohmayr
pushed a commit
that referenced
this pull request
Mar 13, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 31, 2026
chalmerlowe
pushed a commit
that referenced
this pull request
Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>bigframes: 2.39.0</summary> ## [2.39.0](googleapis/python-bigquery-dataframes@v2.38.0...v2.39.0) (2026-03-31) ### Features * add `df.bigquery.ai.forecast` method to pandas dataframe accessor (#2518) ([1126cec9](googleapis/python-bigquery-dataframes@1126cec9)) * support full round-trip persistence for multimodal reference cols (#2511) ([494a0a11](googleapis/python-bigquery-dataframes@494a0a11)) * expose DataFrame.bigquery in both pandas and bigframes DataFrames (#2533) ([69fe3176](googleapis/python-bigquery-dataframes@69fe3176)) ### Bug Fixes * to_gbq may swap data columns when replace table (#2532) ([17ecc65e](googleapis/python-bigquery-dataframes@17ecc65e)) * handle aggregate operations on empty selections (#2510) ([34fb5daa](googleapis/python-bigquery-dataframes@34fb5daa)) * Localize BigQuery log suppression for gbq.py (#2541) ([af49ca29](googleapis/python-bigquery-dataframes@af49ca29)) * Respect remote function config changes even if logic unchanged (#2512) ([b9524284](googleapis/python-bigquery-dataframes@b9524284)) * support melting empty DataFrames without crashing (#2509) ([e8c4603](googleapis/python-bigquery-dataframes@e8c46032)) ### Performance Improvements * Make executor data uploads async internally (#2529) ([96597f0b](googleapis/python-bigquery-dataframes@96597f0b)) ### Documentation * gemini retouch of the index page for seo (#2514) ([2e5311e2](googleapis/python-bigquery-dataframes@2e5311e2)) * Rename Blob column references to ObjectRef column (#2535) ([44e0ffd9](googleapis/python-bigquery-dataframes@44e0ffd9)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2531 as diffbase.In doing this, I realized it's a bit tedious to have to write two classes (page and iterator) for each method. It may be more user-friendly to collapse back into one class. I think I could do it mostly by just making anything that is accessed viaself.page.fooasself.page_foo.