Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Cut 0.20.1 datastore release.#2530

Merged
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:cut-datastore-0.20.1dhermes/google-cloud-python:cut-datastore-0.20.1Copy head branch name to clipboard
Oct 12, 2016
Merged

Cut 0.20.1 datastore release.#2530
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:cut-datastore-0.20.1dhermes/google-cloud-python:cut-datastore-0.20.1Copy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

/cc @jonparrott

Note we still don't have an automated story for twine uploads (and can't really get one until we straighten out tags)

@dhermes dhermes added api: datastore Issues related to the Datastore API. packaging labels Oct 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2016
@dhermes

dhermes commented Oct 12, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver Not sure what the right move is for getting the release note content. Looking at the history for the datastore/ root dir:

https://github.com/GoogleCloudPlatform/google-cloud-python/commits/master/datastore

it seems like #2423 and #2496 are the only relevant changes.

From the CLI:

$ git log umbrella-0.20.0..HEAD datastore/

it indicates #2423 was already in the 0.20.0 release. (Confirmed.)

@tseaver

tseaver commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

Draft of release note:

Datastore 0.20.1

@tseaver

tseaver commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

@dhermes dhermes merged commit a55974b into googleapis:master Oct 12, 2016
@dhermes dhermes deleted the cut-datastore-0.20.1 branch October 12, 2016 17:15
@dhermes

dhermes commented Oct 12, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver What tag should I push?

@dhermes

dhermes commented Oct 12, 2016

Copy link
Copy Markdown
Contributor Author

I just pushed https://pypi.python.org/pypi/google-cloud-datastore/0.20.1 via

$ git worktree add ../do-release origin/master
$ cd ../do-release/datastore
$ python setup.py sdist bdist_wheel
$ twine upload dist/*

@tseaver

tseaver commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

@dhermes I guess 0.20.1-datastore?

@tseaver

tseaver commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

@dhermes 0.20.1-datastore, I guess? I would prefer datastore-0.20.1. Maybe we could tag it twice, once for "real" semantics and once to make RTD happy?

@dhermes

dhermes commented Oct 13, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver both are PEP420 invalid. The "best" valid choice is '0.20.1+datastore'.

>>> from packaging.version import Version
>>> v = Version('0.20.1-datastore')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/packaging/version.py", line 202, in __init__
    raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: '0.20.1-datastore'
>>> v = Version('datastore-0.20.1')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/packaging/version.py", line 202, in __init__
    raise InvalidVersion("Invalid version: '{0}'".format(version))
packaging.version.InvalidVersion: Invalid version: 'datastore-0.20.1'

I am pretty 👎 on tagging twice just for name aliasing. However, I was under the impression that in #2462 we said we might ignore the stable for non google-cloud-core releases?

@tseaver

tseaver commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

If we tag the umbrella project with PEP-420 compatible tags at "appropriate" points, that would let us trigger RTD rebuilds for stable. We could even have a page listing the latest releases of the sub-projects.

@dhermes

dhermes commented Oct 14, 2016

Copy link
Copy Markdown
Contributor Author

Not sure what you mean here. We can only tag one project / GitHub repo. It seems like you're suggesting having docs only tags separate from release only tags (on our git repo), yes?

@tseaver

tseaver commented Oct 14, 2016

Copy link
Copy Markdown
Contributor

If we tag sub-project releases in a way that doesn't cause RTD to rebuild stable, we can still generate tags which do trigger a stable rebuild on RTD for the "umbrella" package.

@dhermes

dhermes commented Oct 18, 2016

Copy link
Copy Markdown
Contributor Author

So you're saying stable would only be built for releases of google-cloud? Is this "incorrect" in the sense that a bound like datastore >= 0.20.0 means that both 0.20.0 and 0.20.1 are valid in the stable docs (and so we should have the latest one released)?

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
ohmayr pushed a commit that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.