On Travis, follow package dependency graph to expand package list.#2487
On Travis, follow package dependency graph to expand package list.#2487dhermes wants to merge 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:compute-dep-graphdhermes/google-cloud-python:compute-dep-graphCopy head branch name to clipboard
Conversation
|
@dhermes can you fix the conflicts? |
Using boilerplate code snippet in each setup.py to load the requirements.txt and adding the requirements.txt file to MANIFEST.in file.
31d2f51 to
f2b87af
Compare
tseaver
left a comment
There was a problem hiding this comment.
I am -1 on the "parse requirements.txt" approach:
- The
requirements.txtformat is effectively an internal implementation detail ofpip: they provide no public API for parsing it. - In the words of the PyPA docs and @dstufft, it is intended to support "application deployments", not as a substitute driver for
install_requires/ "library requirements."
I believe we would be better off leaving install_requires as the definitive version spec for the library, and using the pkg_resources API in our scripts to get the dependency metadata we need.
/cc @jonparrott
|
@tseaver SGTM. @jonparrott and I discussed and I view I'll whip up a proof of concept that parses our |
|
@dhermes To do the analysis on Travis, we are going to have them installed somewhere, likely into a |
Co-authored-by: Victor Chudnovsky <vchudnov@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
To make computing the dependency graph easier I moved the requirements of each package into a
requirements.txtfile.I'm happy to instead write a custom
setup.pyparser but decided that the route of less code was "better" in some sense.