Move dns code into a subpackage#2428
Merged
dhermes merged 2 commits intoSep 26, 2016
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-dns-subpackagedhermes/google-cloud-python:make-dns-subpackageCopy head branch name to clipboard
Merged
Move dns code into a subpackage#2428dhermes merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:make-dns-subpackagedhermes/google-cloud-python:make-dns-subpackageCopy head branch name to clipboard
dhermes merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-dns-subpackagedhermes/google-cloud-python:make-dns-subpackageCopy head branch name to clipboard
Conversation
Done via: $ mkdir -p dns/google/cloud $ cp google/__init__.py dns/google/__init__.py $ git add dns/google/__init__.py $ cp google/cloud/__init__.py dns/google/cloud/__init__.py $ git add dns/google/cloud/__init__.py $ git mv google/cloud/dns dns/google/cloud/dns $ git mv unit_tests/dns dns/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-dns as a dependency to the umbrella
package
- Adding the dns subdirectory into the list of packages
for verifying the docs
- Incorporating the dns subdirectory into the umbrella
coverage report
- Adding the dns only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the dns
tox config
32 tasks
theacodes
approved these changes
Sep 26, 2016
theacodes
left a comment
Contributor
There was a problem hiding this comment.
LGTM with small teensy nit
| Quick Start | ||
| ----------- | ||
|
|
||
| :: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677 <details><summary>bigframes: 2.34.0</summary> ## [2.34.0](googleapis/python-bigquery-dataframes@v2.33.0...v2.34.0) (2026-02-02) ### Features * add `bigframes.pandas.options.experiments.sql_compiler` for switching the backend compiler (#2417) ([7eba6ee03f07938315d99e2aeaf72368c02074cf](googleapis/python-bigquery-dataframes@7eba6ee)) * add bigquery.ml.generate_embedding function (#2422) ([35f3f5e6f8c64b47e6e7214034f96f047785e647](googleapis/python-bigquery-dataframes@35f3f5e)) * add bigquery.create_external_table method (#2415) ([76db2956e505aec4f1055118ac7ca523facc10ff](googleapis/python-bigquery-dataframes@76db295)) * add deprecation warnings for .blob accessor and read_gbq_object_table (#2408) ([7261a4ea5cdab6b30f5bc333501648c60e70be59](googleapis/python-bigquery-dataframes@7261a4e)) * add bigquery.ml.generate_text function (#2403) ([5ac681028624de15e31f0c2ae360b47b2dcf1e8d](googleapis/python-bigquery-dataframes@5ac6810)) ### Bug Fixes * broken job url (#2411) ([fcb5bc1761c656e1aec61dbcf96a36d436833b7a](googleapis/python-bigquery-dataframes@fcb5bc1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3