Move pubsub code into a subpackage#2419
Merged
dhermes merged 3 commits intoSep 26, 2016
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-pubsub-subpackagedhermes/google-cloud-python:make-pubsub-subpackageCopy head branch name to clipboard
Merged
Move pubsub code into a subpackage#2419dhermes merged 3 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:make-pubsub-subpackagedhermes/google-cloud-python:make-pubsub-subpackageCopy head branch name to clipboard
dhermes merged 3 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-pubsub-subpackagedhermes/google-cloud-python:make-pubsub-subpackageCopy head branch name to clipboard
Conversation
This was referenced Sep 25, 2016
theacodes
approved these changes
Sep 25, 2016
df84621 to
6ed1a94
Compare
Contributor
|
LGTM |
Contributor
Author
|
Not going to merge this, going to merge #2420 and GitHub will magically close this PR. |
Done via: $ mkdir -p pubsub/google/cloud $ cp google/__init__.py pubsub/google/__init__.py $ git add pubsub/google/__init__.py $ cp google/cloud/__init__.py pubsub/google/cloud/__init__.py $ git add pubsub/google/cloud/__init__.py $ git mv google/cloud/pubsub pubsub/google/cloud/pubsub $ git mv unit_tests/pubsub pubsub/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-pubsub as a dependency to the umbrella
package
- Adding the pubsub subdirectory into the list of packages
for verifying the docs
- Incorporating the pubsub subdirectory into the umbrella
coverage report
- Adding the pubsub only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the pubsub
tox config
6ed1a94 to
27380f9
Compare
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This PR refines the visual feedback provided during operation progress. Specifically, it prevents the display of a standalone "✅ Completed." message and green checkmark when no query execution information (like slot time or bytes processed) is available. This often occurs during metadata-only operations or cached results where the "Completed" status is redundant. Fixes #<479944983> 🦕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3
NOTE: Since only
pubsubandlogginghad to remove extra deps fromGRPC_PACKAGESinsetup.py, the 3rd commit is just written the old-fashioned way.