Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move bigquery code into a subpackage#2418

Merged
dhermes merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-bigquery-subpackagedhermes/google-cloud-python:make-bigquery-subpackageCopy head branch name to clipboard
Sep 26, 2016
Merged

Move bigquery code into a subpackage#2418
dhermes merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:make-bigquery-subpackagedhermes/google-cloud-python:make-bigquery-subpackageCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Sep 25, 2016

Copy link
Copy Markdown
Contributor

This PR was created via: https://gist.github.com/dhermes/e239691aa584bd56a5352e34aad27cf3

export PROJECT_DIR="${HOME}/google-cloud-python"
export READMES_DIR="${HOME}/i-wrote-some-readmes-for-2357"
cd ${PROJECT_DIR}
git worktree add -b make-bigquery-subpackage ../hotfix official/master
python make_commits.py \
  --git-root "${PROJECT_DIR}/../hotfix" \
  --package bigquery \
  --package-name "Google BigQuery" \
  --readme "${READMES_DIR}/bigquery/README.rst"

@dhermes dhermes added api: bigquery Issues related to the BigQuery API. packaging labels Sep 25, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2016
Comment thread bigquery/README.rst Outdated
query.run()

for row in query.rows:
print row

This comment was marked as spam.

@dhermes dhermes force-pushed the make-bigquery-subpackage branch from 6b7e52e to dec1f3d Compare September 26, 2016 16:34
@dhermes

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

Folded the print(...) change into 2nd commit

@tseaver

tseaver commented Sep 26, 2016

Copy link
Copy Markdown
Contributor

LGTM

Done via:

$ mkdir -p bigquery/google/cloud
$ cp google/__init__.py bigquery/google/__init__.py
$ git add bigquery/google/__init__.py
$ cp google/cloud/__init__.py bigquery/google/cloud/__init__.py
$ git add bigquery/google/cloud/__init__.py
$ git mv google/cloud/bigquery bigquery/google/cloud/bigquery
$ git mv unit_tests/bigquery bigquery/unit_tests
- Adding README, setup.py, MANIFEST.in, .coveragerc and tox.ini
- Adding google-cloud-bigquery as a dependency to the umbrella
  package
- Adding the bigquery subdirectory into the list of packages
  for verifying the docs
- Incorporating the bigquery subdirectory into the umbrella
  coverage report
- Adding the bigquery only tox tests to the Travis config
- Adding {toxinidir}/../core as a dependency for the bigquery
  tox config
@dhermes dhermes force-pushed the make-bigquery-subpackage branch from dec1f3d to 9670183 Compare September 26, 2016 19:44
@dhermes

dhermes commented Sep 26, 2016

Copy link
Copy Markdown
Contributor Author

As with #2416 and #2417, Pushed to resolve rebase conflict and re-ran script. Won't wait on Travis since a) that could be awhile and b) this will be painful.

@dhermes dhermes merged commit afd0ae4 into googleapis:master Sep 26, 2016
@dhermes dhermes deleted the make-bigquery-subpackage branch September 26, 2016 19:45
parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.