Review cleanup for PR #2344.#2376
Merged
Merged
Review cleanup for PR #2344.#2376
Conversation
daspecster
reviewed
Sep 21, 2016
| bucket = client.get_bucket('<your-bucket-name>') | ||
| blob = bucket.blob('my-test-file.txt') | ||
| blob.upload_from_string('this is test content!') No newline at end of file | ||
| blob.upload_from_string('this is test content!') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
daspecster
reviewed
Sep 21, 2016
| ... print(' transcript: %s' % (alternative["transcript"],)) | ||
| ... print(' confidence: %s' % (alternative["confidence"],)) | ||
| ... print('transcript: ' + alternative['transcript']) | ||
| ... print('confidence: ' + alternative['confidence']) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM |
Contributor
|
Did travis slow down on us again today? |
Contributor
|
@daspecster We can apparently get throttled due to builds throughout the organization. |
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
We will have more logging utilities in the future. It's better to organize them into a separate directory now. Related issue: 406578908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@daspecster After this is in, feel free to run with the implementation (e.g. system tests, all features, etc.)
Remaining review issues not fixed by this PR: