Making license headers in Python files more uniform#2370
Merged
dhermes merged 2 commits intoSep 22, 2016
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:license-header-checkdhermes/google-cloud-python:license-header-checkCopy head branch name to clipboard
Merged
Making license headers in Python files more uniform#2370dhermes merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom dhermes:license-header-checkdhermes/google-cloud-python:license-header-checkCopy head branch name to clipboard
dhermes merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:license-header-checkdhermes/google-cloud-python:license-header-checkCopy head branch name to clipboard
Conversation
dhermes
commented
Sep 20, 2016
Contributor
- Originally started as a check for which files didn't have license headers (due to Moving core into designated package. #2367 (comment))
- Used a script to verify: https://gist.github.com/dhermes/17177b603e2b22902334947d9871529c
- Maybe we should incorporate the script into our build rule to prevent files checked in with bad or missing license headers?
- Should the script be extended to incorporate more than just Python files?
Done via: $ git grep -l '# Copyright 2016 Google Inc. All Rights Reserved.' | \ > xargs sed -i 's/All Rights Reserved/All rights reserved/g'
Also adding license headers where they are missing. Also had to tweak the max lines allowed in a test module due to added license header. Used: https://gist.github.com/dhermes/17177b603e2b22902334947d9871529c
Contributor
|
I'm 👍 for point number 3. I added #2371 to discuss. These updates LGTM. |
daspecster
approved these changes
Sep 21, 2016
This was referenced Sep 23, 2016
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.