Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Vision image properties#2320

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-image-propertiesdaspecster/google-cloud-python:vision-image-propertiesCopy head branch name to clipboard
Sep 15, 2016
Merged

Vision image properties#2320
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:vision-image-propertiesdaspecster/google-cloud-python:vision-image-propertiesCopy head branch name to clipboard

Conversation

@daspecster

@daspecster daspecster commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

Based from #2319

Adds the image properties detection API for Vision.

This adds a fairly large ImagePropertiesAnnotation with several classes to absorb the color data in the response.

✅ Also after #2319 is merged I will clean up the weird commit history.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2016
@daspecster daspecster force-pushed the vision-image-properties branch from a08bd4e to c741476 Compare September 15, 2016 02:38
@daspecster daspecster force-pushed the vision-image-properties branch 2 times, most recently from 71f4e4b to e99b0e2 Compare September 15, 2016 17:52
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2016
@daspecster

Copy link
Copy Markdown
Contributor Author

@tseaver, I cleaned this up so it should be ready to checkout as well.

@daspecster daspecster force-pushed the vision-image-properties branch from e99b0e2 to acc96bc Compare September 15, 2016 19:33
Comment thread google/cloud/vision/color.py Outdated

@property
def red(self):
"""Red color.

This comment was marked as spam.

return self._red

@property
def green(self):

This comment was marked as spam.

"""
return self._green

@property

This comment was marked as spam.

Comment thread google/cloud/vision/color.py Outdated

:type red: int
:param red: The amount of red in the color as a value in the interval
[0, 1].

This comment was marked as spam.

This comment was marked as spam.

:param color: RGB components of the color.

:type score: float
:param score: Image-specific score for this color. Value in range [0, 1].

This comment was marked as spam.

This comment was marked as spam.

Comment thread unit_tests/vision/_fixtures.py Outdated
}
}
]
}

This comment was marked as spam.

This comment was marked as spam.

@daspecster

Copy link
Copy Markdown
Contributor Author

@tseaver, updated everything except the score docstring. That value is copied from their docs, but I can't seem to find a better explanation of it.

@tseaver

tseaver commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

@daspecster daspecster force-pushed the vision-image-properties branch from 5fdb9da to 5e0da90 Compare September 15, 2016 21:23
@daspecster daspecster merged commit 0f5d982 into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
@daspecster daspecster deleted the vision-image-properties branch January 24, 2017 15:17
parthea pushed a commit that referenced this pull request Apr 1, 2026
Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a
[bug/issue](https://github.com/googleapis/python-bigquery-dataframes/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.