Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix logging/pubub system tests#2260

Merged
tseaver merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:pubsub-logging-post-2223-system-testsCopy head branch name to clipboard
Sep 7, 2016
Merged

Fix logging/pubub system tests#2260
tseaver merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
tseaver:pubsub-logging-post-2223-system-testsCopy head branch name to clipboard

Conversation

@tseaver

@tseaver tseaver commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

Broken after #2223.

  • Namespace packages break use of 'Client' from package.
  • Shorten bucket / topic names to match limits.
  • Stop sharing sink / metric names across tests (brush clearing to find the real issue with bucket / topic names).

- Namespace packages break use of 'Client' from package.

- Shorten bucket / topic names to match limits.

- Stop sharing sink / metric names across tests.
@tseaver tseaver added testing api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2016
@daspecster

Copy link
Copy Markdown
Contributor

LGTM pending travis!

@tseaver

tseaver commented Sep 7, 2016

Copy link
Copy Markdown
Contributor Author

Travis will pass for the PR (only changes to system_tests/), but fail on merge (due to other #2259 issues).

@tseaver tseaver merged commit 2499735 into googleapis:master Sep 7, 2016
@tseaver tseaver deleted the pubsub-logging-post-2223-system-tests branch September 7, 2016 18:38
@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat: add created/started/ended attribute to RowIterator.

* fix annotation

* links update

* mypy fix

* Update google/cloud/bigquery/query.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* Update google/cloud/bigquery/table.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* Update google/cloud/bigquery/table.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* Update google/cloud/bigquery/query.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* Update google/cloud/bigquery/query.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* Update google/cloud/bigquery/job/query.py

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>

* fix unit test

---------

Co-authored-by: Tim Sweña (Swast) <tswast@gmail.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.