Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix monitoring documentation TOC.#2247

Merged
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:fix-monitoring-tocdaspecster/google-cloud-python:fix-monitoring-tocCopy head branch name to clipboard
Sep 6, 2016
Merged

Fix monitoring documentation TOC.#2247
daspecster merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
daspecster:fix-monitoring-tocdaspecster/google-cloud-python:fix-monitoring-tocCopy head branch name to clipboard

Conversation

@daspecster

Copy link
Copy Markdown
Contributor

Partial resolution for #2246.

The table of contents references were wrong.

@daspecster daspecster added docs api: monitoring Issues related to the Cloud Monitoring API. labels Sep 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2016
{
"title": "Time Series Query",
"type": "gcloud/monitoring/index/query"
"type": "gcloud/monitoring/query/query"

This comment was marked as spam.

@dhermes

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

@daspecster Let's once and for all write a script for generating this JSON. Hand-crafted JSON is just a bad idea. If we want custom edits, we'll write them in Python and make the script toss them into the autogenerated dictionary.

@dhermes

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

LGTM

@daspecster

Copy link
Copy Markdown
Contributor Author

@dhermes yeah, I've started doing this in a branch for another issue. I'll just go full tilt on this for the TOC. I should have a PR for it today.

@daspecster daspecster merged commit 89eed0e into googleapis:master Sep 6, 2016
@daspecster daspecster deleted the fix-monitoring-toc branch September 6, 2016 15:58
@dhermes

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

for another issue

It should be a standalone anyhow

@daspecster

Copy link
Copy Markdown
Contributor Author

Yeah, I was thinking of just making the toc a python dict? How does that sound for the first PR?

@dhermes

dhermes commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

It doesn't amount to any actual change.

@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.