Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove some unused features of gcloud.streaming.#2240

Merged
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:remove-some-streaming-yagnidhermes/google-cloud-python:remove-some-streaming-yagniCopy head branch name to clipboard
Sep 2, 2016
Merged

Remove some unused features of gcloud.streaming.#2240
dhermes merged 1 commit into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
dhermes:remove-some-streaming-yagnidhermes/google-cloud-python:remove-some-streaming-yagniCopy head branch name to clipboard

Conversation

@dhermes

@dhermes dhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor

Towards #1998.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2016
@daspecster

Copy link
Copy Markdown
Contributor

The idea is just moving the usage of httplib2 upward since get_http doesn't really get used?

@dhermes

dhermes commented Sep 2, 2016

Copy link
Copy Markdown
Contributor Author

No we want to get a full-on divorce from httplib2. gcloud.streaming is huge and I'm just sifting through it right now trying to figure out what the core parts are. So along the way I realized we weren't using these features.

@daspecster

Copy link
Copy Markdown
Contributor

LGTM pending travis.

@dhermes dhermes merged commit f1ffbfd into googleapis:master Sep 2, 2016
@dhermes dhermes deleted the remove-some-streaming-yagni branch September 2, 2016 21:05
@dhermes dhermes mentioned this pull request Sep 19, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.